2
0

Display Valkey version on admin dashboard (#35785)

This commit is contained in:
Yamagishi Kazutoshi
2025-09-10 19:58:51 +09:00
committed by GitHub
parent eb118d8523
commit ffaa672fd6
5 changed files with 104 additions and 33 deletions

View File

@@ -9,14 +9,44 @@ RSpec.describe Admin::Metrics::Dimension::SoftwareVersionsDimension do
let(:end_at) { Time.now.utc }
let(:limit) { 10 }
let(:params) { ActionController::Parameters.new }
let(:redis_human_key) { 'Redis' }
let(:redis_version) { '7.4.5' }
let(:redis_info) { { 'redis_version' => redis_version } }
describe '#data' do
it 'reports on the running software' do
expect(subject.data.map(&:symbolize_keys))
.to include(
include(key: 'mastodon', value: Mastodon::Version.to_s),
include(key: 'ruby', value: include(RUBY_VERSION))
)
shared_examples 'shared behavior' do
before do
allow(subject).to receive(:redis_info).and_return(redis_info) # rubocop:disable RSpec/SubjectStub
end
it 'reports on the running software' do
expect(subject.data.map(&:symbolize_keys))
.to include(
include(key: 'mastodon', value: Mastodon::Version.to_s),
include(key: 'ruby', value: include(RUBY_VERSION)),
include(key: 'redis', human_key: redis_human_key, value: redis_version)
)
end
end
context 'when using redis' do
it_behaves_like 'shared behavior'
end
context 'when using valkey' do
let(:redis_human_key) { 'Valkey' }
let(:redis_version) { '8.1.3' }
let(:redis_info) { { 'valkey_version' => redis_version } }
it_behaves_like 'shared behavior'
end
context 'when using dragonfly' do
let(:redis_human_key) { 'Dragonfly' }
let(:redis_version) { 'df-v1.32.0' }
let(:redis_info) { { 'dragonfly_version' => redis_version } }
it_behaves_like 'shared behavior'
end
end
end

View File

@@ -10,14 +10,41 @@ RSpec.describe Admin::Metrics::Dimension::SpaceUsageDimension do
let(:limit) { 10 }
let(:params) { ActionController::Parameters.new }
let(:redis_human_key) { 'Redis' }
let(:redis_info) { { 'redis_version' => '7.4.5', 'used_memory' => 1_024 } }
describe '#data' do
it 'reports on used storage space' do
expect(subject.data.map(&:symbolize_keys))
.to include(
include(key: 'media', value: /\d/),
include(key: 'postgresql', value: /\d/),
include(key: 'redis', value: /\d/)
)
shared_examples 'shared behavior' do
before do
allow(subject).to receive(:redis_info).and_return(redis_info) # rubocop:disable RSpec/SubjectStub
end
it 'reports on used storage space' do
expect(subject.data.map(&:symbolize_keys))
.to include(
include(key: 'media', value: /\d/),
include(key: 'postgresql', value: /\d/),
include(key: 'redis', human_key: redis_human_key, value: /\d/)
)
end
end
context 'when using redis' do
it_behaves_like 'shared behavior'
end
context 'when using valkey' do
let(:redis_human_key) { 'Valkey' }
let(:redis_info) { { 'valkey_version' => '8.1.3', 'used_memory' => 1_024 } }
it_behaves_like 'shared behavior'
end
context 'when using dragonfly' do
let(:redis_human_key) { 'Dragonfly' }
let(:redis_info) { { 'dragonfly_version' => 'df-v1.32.0', 'used_memory' => 1_024 } }
it_behaves_like 'shared behavior'
end
end
end