techhub/mastodon
2
0
Fork 0
Code Activity

Simplify WebauthnCredential constant limit math (#35107)

Browse Source
This commit is contained in:
Matt Jankowski
2025-06-20 06:04:14 -04:00
committed by GitHub
parent 0ec6c26af3
commit e9b1c1edfe
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/webauthn_credential.rb
View File

@@ -21,5 +21,5 @@ class WebauthnCredential < ApplicationRecord
validates :external_id, uniqueness: true validates :external_id, uniqueness: true
validates :nickname, uniqueness: { scope: :user_id } validates :nickname, uniqueness: { scope: :user_id }
validates :sign_count, validates :sign_count,
numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: SIGN_COUNT_LIMIT - 1 } numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than: SIGN_COUNT_LIMIT }
end end

2
spec/models/webauthn_credential_spec.rb
View File

@@ -14,6 +14,6 @@ RSpec.describe WebauthnCredential do
it { is_expected.to validate_uniqueness_of(:external_id) } it { is_expected.to validate_uniqueness_of(:external_id) }
it { is_expected.to validate_uniqueness_of(:nickname).scoped_to(:user_id) } it { is_expected.to validate_uniqueness_of(:nickname).scoped_to(:user_id) }
it { is_expected.to validate_numericality_of(:sign_count).only_integer.is_greater_than_or_equal_to(0).is_less_than_or_equal_to(described_class::SIGN_COUNT_LIMIT - 1) } it { is_expected.to validate_numericality_of(:sign_count).only_integer.is_greater_than_or_equal_to(0).is_less_than(described_class::SIGN_COUNT_LIMIT) }
end end
end end