techhub/mastodon
2
0
Fork 0
Code Activity

Add coverage to user spec for missing last_sign_in_at scenario (#35587)

Browse Source
This commit is contained in:
Matt Jankowski
2025-07-30 09:46:58 -04:00
committed by GitHub
parent 139025fce0
commit e8e6cf9510
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spec/models/user_spec.rb
View File

@@ -163,12 +163,13 @@ RSpec.describe User do
describe '#update_sign_in!' do
context 'with an existing user' do
let!(:user) { Fabricate :user, last_sign_in_at: 10.days.ago, current_sign_in_at: 1.hour.ago, sign_in_count: 123 }
let!(:user) { Fabricate :user, last_sign_in_at: 10.days.ago, current_sign_in_at:, sign_in_count: 123 }
let(:current_sign_in_at) { 1.hour.ago }
context 'with new sign in false' do
it 'updates timestamps but not counts' do
expect { user.update_sign_in!(new_sign_in: false) }
.to change(user, :last_sign_in_at)
.to change(user, :last_sign_in_at).to(current_sign_in_at)
.and change(user, :current_sign_in_at)
.and not_change(user, :sign_in_count)
end
@@ -177,11 +178,22 @@ RSpec.describe User do
context 'with new sign in true' do
it 'updates timestamps and counts' do
expect { user.update_sign_in!(new_sign_in: true) }
.to change(user, :last_sign_in_at)
.to change(user, :last_sign_in_at).to(current_sign_in_at)
.and change(user, :current_sign_in_at)
.and change(user, :sign_in_count).by(1)
end
end
context 'when the user does not have a current_sign_in_at value' do
let(:current_sign_in_at) { nil }
before { travel_to(1.minute.ago) }
it 'updates last sign in to now' do
expect { user.update_sign_in! }
.to change(user, :last_sign_in_at).to(Time.now.utc)
end
end
end
context 'with a new user' do