Remove the outgoing_quotes feature flag, making the feature unconditional (#36130)

spec/lib/activitypub/activity/quote_request_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe ActivityPub::Activity::QuoteRequest, feature: :outgoing_quotes do
+RSpec.describe ActivityPub::Activity::QuoteRequest do
   let(:sender)    { Fabricate(:account, domain: 'example.com') }
   let(:recipient) { Fabricate(:account) }
   let(:quoted_post) { Fabricate(:status, account: recipient) }

spec/lib/status_cache_hydrator_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe StatusCacheHydrator do
         end
       end
 
-      context 'when handling a status with a quote policy', feature: :outgoing_quotes do
+      context 'when handling a status with a quote policy' do
         let(:status) { Fabricate(:status, quote_approval_policy: Status::QUOTE_APPROVAL_POLICY_FLAGS[:followers] << 16) }
 
         before do

spec/requests/api/v1/statuses/interaction_policies_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe 'Interaction policies', feature: :outgoing_quotes do
+RSpec.describe 'Interaction policies' do
   let(:user)    { Fabricate(:user) }
   let(:scopes)  { 'write:statuses' }
   let(:token)   { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }

spec/requests/api/v1/statuses_spec.rb

@@ -158,7 +158,7 @@ RSpec.describe '/api/v1/statuses' do
         end
       end
 
-      context 'without a quote policy', feature: :outgoing_quotes do
+      context 'without a quote policy' do
         let(:user) do
           Fabricate(:user, settings: { default_quote_policy: 'followers' })
         end
@@ -180,7 +180,7 @@ RSpec.describe '/api/v1/statuses' do
         end
       end
 
-      context 'without a quote policy and the user defaults to nobody', feature: :outgoing_quotes do
+      context 'without a quote policy and the user defaults to nobody' do
         let(:user) do
           Fabricate(:user, settings: { default_quote_policy: 'nobody' })
         end
@@ -202,7 +202,7 @@ RSpec.describe '/api/v1/statuses' do
         end
       end
 
-      context 'with a quote policy', feature: :outgoing_quotes do
+      context 'with a quote policy' do
         let(:quoted_status) { Fabricate(:status, account: user.account) }
         let(:params) do
           {
@@ -227,7 +227,7 @@ RSpec.describe '/api/v1/statuses' do
         end
       end
 
-      context 'with a self-quote post', feature: :outgoing_quotes do
+      context 'with a self-quote post' do
         let(:quoted_status) { Fabricate(:status, account: user.account) }
         let(:params) do
           {
@@ -248,7 +248,7 @@ RSpec.describe '/api/v1/statuses' do
         end
       end
 
-      context 'with a self-quote post and a CW but no text', feature: :outgoing_quotes do
+      context 'with a self-quote post and a CW but no text' do
         let(:quoted_status) { Fabricate(:status, account: user.account) }
         let(:params) do
           {
@@ -420,7 +420,7 @@ RSpec.describe '/api/v1/statuses' do
       context 'when updating only the quote policy' do
         let(:params) { { status: status.text, quote_approval_policy: 'public' } }
 
-        it 'updates the status', :aggregate_failures, feature: :outgoing_quotes do
+        it 'updates the status', :aggregate_failures do
           expect { subject }
             .to change { status.reload.quote_approval_policy }.to(Status::QUOTE_APPROVAL_POLICY_FLAGS[:public] << 16)
 

spec/serializers/activitypub/note_serializer_spec.rb

@@ -58,7 +58,7 @@ RSpec.describe ActivityPub::NoteSerializer do
     end
   end
 
-  context 'with a quote policy', feature: :outgoing_quotes do
+  context 'with a quote policy' do
     let(:parent) { Fabricate(:status, quote_approval_policy: Status::QUOTE_APPROVAL_POLICY_FLAGS[:followers] << 16) }
 
     it 'has the expected shape' do