Remove option to disable access to local topic feeds for logged-in users (#36703)
This commit is contained in:
@@ -35,7 +35,7 @@ interface InitialStateMeta {
|
|||||||
streaming_api_base_url: string;
|
streaming_api_base_url: string;
|
||||||
local_live_feed_access: 'public' | 'authenticated' | 'disabled';
|
local_live_feed_access: 'public' | 'authenticated' | 'disabled';
|
||||||
remote_live_feed_access: 'public' | 'authenticated' | 'disabled';
|
remote_live_feed_access: 'public' | 'authenticated' | 'disabled';
|
||||||
local_topic_feed_access: 'public' | 'authenticated' | 'disabled';
|
local_topic_feed_access: 'public' | 'authenticated';
|
||||||
remote_topic_feed_access: 'public' | 'authenticated' | 'disabled';
|
remote_topic_feed_access: 'public' | 'authenticated' | 'disabled';
|
||||||
title: string;
|
title: string;
|
||||||
show_trends: boolean;
|
show_trends: boolean;
|
||||||
|
|||||||
@@ -87,6 +87,7 @@ class Form::AdminSettings
|
|||||||
DOMAIN_BLOCK_AUDIENCES = %w(disabled users all).freeze
|
DOMAIN_BLOCK_AUDIENCES = %w(disabled users all).freeze
|
||||||
REGISTRATION_MODES = %w(open approved none).freeze
|
REGISTRATION_MODES = %w(open approved none).freeze
|
||||||
FEED_ACCESS_MODES = %w(public authenticated disabled).freeze
|
FEED_ACCESS_MODES = %w(public authenticated disabled).freeze
|
||||||
|
ALTERNATE_FEED_ACCESS_MODES = %w(public authenticated).freeze
|
||||||
LANDING_PAGE = %w(trends about local_feed).freeze
|
LANDING_PAGE = %w(trends about local_feed).freeze
|
||||||
|
|
||||||
attr_accessor(*KEYS)
|
attr_accessor(*KEYS)
|
||||||
@@ -99,7 +100,7 @@ class Form::AdminSettings
|
|||||||
validates :show_domain_blocks_rationale, inclusion: { in: DOMAIN_BLOCK_AUDIENCES }, if: -> { defined?(@show_domain_blocks_rationale) }
|
validates :show_domain_blocks_rationale, inclusion: { in: DOMAIN_BLOCK_AUDIENCES }, if: -> { defined?(@show_domain_blocks_rationale) }
|
||||||
validates :local_live_feed_access, inclusion: { in: FEED_ACCESS_MODES }, if: -> { defined?(@local_live_feed_access) }
|
validates :local_live_feed_access, inclusion: { in: FEED_ACCESS_MODES }, if: -> { defined?(@local_live_feed_access) }
|
||||||
validates :remote_live_feed_access, inclusion: { in: FEED_ACCESS_MODES }, if: -> { defined?(@remote_live_feed_access) }
|
validates :remote_live_feed_access, inclusion: { in: FEED_ACCESS_MODES }, if: -> { defined?(@remote_live_feed_access) }
|
||||||
validates :local_topic_feed_access, inclusion: { in: FEED_ACCESS_MODES }, if: -> { defined?(@local_topic_feed_access) }
|
validates :local_topic_feed_access, inclusion: { in: ALTERNATE_FEED_ACCESS_MODES }, if: -> { defined?(@local_topic_feed_access) }
|
||||||
validates :remote_topic_feed_access, inclusion: { in: FEED_ACCESS_MODES }, if: -> { defined?(@remote_topic_feed_access) }
|
validates :remote_topic_feed_access, inclusion: { in: FEED_ACCESS_MODES }, if: -> { defined?(@remote_topic_feed_access) }
|
||||||
validates :media_cache_retention_period, :content_cache_retention_period, :backups_retention_period, numericality: { only_integer: true }, allow_blank: true, if: -> { defined?(@media_cache_retention_period) || defined?(@content_cache_retention_period) || defined?(@backups_retention_period) }
|
validates :media_cache_retention_period, :content_cache_retention_period, :backups_retention_period, numericality: { only_integer: true }, allow_blank: true, if: -> { defined?(@media_cache_retention_period) || defined?(@content_cache_retention_period) || defined?(@backups_retention_period) }
|
||||||
validates :min_age, numericality: { only_integer: true }, allow_blank: true, if: -> { defined?(@min_age) }
|
validates :min_age, numericality: { only_integer: true }, allow_blank: true, if: -> { defined?(@min_age) }
|
||||||
|
|||||||
@@ -43,7 +43,7 @@
|
|||||||
.fields-row
|
.fields-row
|
||||||
.fields-row__column.fields-row__column-6.fields-group
|
.fields-row__column.fields-row__column-6.fields-group
|
||||||
= f.input :local_topic_feed_access,
|
= f.input :local_topic_feed_access,
|
||||||
collection: f.object.class::FEED_ACCESS_MODES,
|
collection: f.object.class::ALTERNATE_FEED_ACCESS_MODES,
|
||||||
include_blank: false,
|
include_blank: false,
|
||||||
label_method: ->(mode) { I18n.t("admin.settings.feed_access.modes.#{mode}") },
|
label_method: ->(mode) { I18n.t("admin.settings.feed_access.modes.#{mode}") },
|
||||||
wrapper: :with_label
|
wrapper: :with_label
|
||||||
|
|||||||
Reference in New Issue
Block a user