Fix list creation limit check (#32869)
This commit is contained in:
		@@ -34,7 +34,7 @@ class List < ApplicationRecord
 | 
				
			|||||||
  private
 | 
					  private
 | 
				
			||||||
 | 
					
 | 
				
			||||||
  def validate_account_lists_limit
 | 
					  def validate_account_lists_limit
 | 
				
			||||||
    errors.add(:base, I18n.t('lists.errors.limit')) if account.lists.count >= PER_ACCOUNT_LIMIT
 | 
					    errors.add(:base, I18n.t('lists.errors.limit')) if account.owned_lists.count >= PER_ACCOUNT_LIMIT
 | 
				
			||||||
  end
 | 
					  end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
  def clean_feed_manager
 | 
					  def clean_feed_manager
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -11,7 +11,11 @@ RSpec.describe List do
 | 
				
			|||||||
    context 'when account has hit max list limit' do
 | 
					    context 'when account has hit max list limit' do
 | 
				
			||||||
      let(:account) { Fabricate :account }
 | 
					      let(:account) { Fabricate :account }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
      before { stub_const 'List::PER_ACCOUNT_LIMIT', 0 }
 | 
					      before do
 | 
				
			||||||
 | 
					        stub_const 'List::PER_ACCOUNT_LIMIT', 1
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					        Fabricate(:list, account: account)
 | 
				
			||||||
 | 
					      end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
      context 'when creating a new list' do
 | 
					      context 'when creating a new list' do
 | 
				
			||||||
        it { is_expected.to_not allow_value(account).for(:account).against(:base).with_message(I18n.t('lists.errors.limit')) }
 | 
					        it { is_expected.to_not allow_value(account).for(:account).against(:base).with_message(I18n.t('lists.errors.limit')) }
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user