Add missing tests for admin/accounts_controller (#7791)
This commit is contained in:
		
				
					committed by
					
						
						Yamagishi Kazutoshi
					
				
			
			
				
	
			
			
			
						parent
						
							0979d4275a
						
					
				
				
					commit
					6151308c47
				
			@@ -3,13 +3,11 @@ require 'rails_helper'
 | 
			
		||||
RSpec.describe Admin::AccountsController, type: :controller do
 | 
			
		||||
  render_views
 | 
			
		||||
 | 
			
		||||
  let(:user) { Fabricate(:user, admin: true) }
 | 
			
		||||
 | 
			
		||||
  before do
 | 
			
		||||
    sign_in user, scope: :user
 | 
			
		||||
  end
 | 
			
		||||
  before { sign_in current_user, scope: :user }
 | 
			
		||||
 | 
			
		||||
  describe 'GET #index' do
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: true) }
 | 
			
		||||
 | 
			
		||||
    around do |example|
 | 
			
		||||
      default_per_page = Account.default_per_page
 | 
			
		||||
      Account.paginates_per 1
 | 
			
		||||
@@ -68,6 +66,7 @@ RSpec.describe Admin::AccountsController, type: :controller do
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
  describe 'GET #show' do
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: true) }
 | 
			
		||||
    let(:account) { Fabricate(:account, username: 'bob') }
 | 
			
		||||
 | 
			
		||||
    it 'returns http success' do
 | 
			
		||||
@@ -75,4 +74,219 @@ RSpec.describe Admin::AccountsController, type: :controller do
 | 
			
		||||
      expect(response).to have_http_status(200)
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
  describe 'POST #subscribe' do
 | 
			
		||||
    subject { post :subscribe, params: { id: account.id } }
 | 
			
		||||
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: admin) }
 | 
			
		||||
    let(:account) { Fabricate(:account) }
 | 
			
		||||
 | 
			
		||||
    context 'when user is admin' do
 | 
			
		||||
      let(:admin) { true }
 | 
			
		||||
 | 
			
		||||
      it { is_expected.to redirect_to admin_account_path(account.id) }
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    context 'when user is not admin' do
 | 
			
		||||
      let(:admin) { false }
 | 
			
		||||
 | 
			
		||||
      it { is_expected.to have_http_status :forbidden }
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
  describe 'POST #unsubscribe' do
 | 
			
		||||
    subject { post :unsubscribe, params: { id: account.id } }
 | 
			
		||||
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: admin) }
 | 
			
		||||
    let(:account) { Fabricate(:account) }
 | 
			
		||||
 | 
			
		||||
    context 'when user is admin' do
 | 
			
		||||
      let(:admin) { true }
 | 
			
		||||
 | 
			
		||||
      it { is_expected.to redirect_to admin_account_path(account.id) }
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    context 'when user is not admin' do
 | 
			
		||||
      let(:admin) { false }
 | 
			
		||||
 | 
			
		||||
      it { is_expected.to have_http_status :forbidden }
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
  describe 'POST #memorialize' do
 | 
			
		||||
    subject { post :memorialize, params: { id: account.id } }
 | 
			
		||||
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: current_user_admin) }
 | 
			
		||||
    let(:account) { Fabricate(:account, user: user) }
 | 
			
		||||
    let(:user) { Fabricate(:user, admin: target_user_admin) }
 | 
			
		||||
 | 
			
		||||
    context 'when user is admin' do
 | 
			
		||||
      let(:current_user_admin) { true }
 | 
			
		||||
 | 
			
		||||
      context 'when target user is admin' do
 | 
			
		||||
        let(:target_user_admin) { true }
 | 
			
		||||
 | 
			
		||||
        it 'fails to memorialize account' do
 | 
			
		||||
          is_expected.to have_http_status :forbidden
 | 
			
		||||
          expect(account.reload).not_to be_memorial
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
 | 
			
		||||
      context 'when target user is not admin' do
 | 
			
		||||
        let(:target_user_admin) { false }
 | 
			
		||||
 | 
			
		||||
        it 'succeeds in memorializing account' do
 | 
			
		||||
          is_expected.to redirect_to admin_account_path(account.id)
 | 
			
		||||
          expect(account.reload).to be_memorial
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    context 'when user is not admin' do
 | 
			
		||||
      let(:current_user_admin) { false }
 | 
			
		||||
 | 
			
		||||
      context 'when target user is admin' do
 | 
			
		||||
        let(:target_user_admin) { true }
 | 
			
		||||
 | 
			
		||||
        it 'fails to memorialize account' do
 | 
			
		||||
          is_expected.to have_http_status :forbidden
 | 
			
		||||
          expect(account.reload).not_to be_memorial
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
 | 
			
		||||
      context 'when target user is not admin' do
 | 
			
		||||
        let(:target_user_admin) { false }
 | 
			
		||||
 | 
			
		||||
        it 'fails to memorialize account' do
 | 
			
		||||
          is_expected.to have_http_status :forbidden
 | 
			
		||||
          expect(account.reload).not_to be_memorial
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
  describe 'POST #enable' do
 | 
			
		||||
    subject { post :enable, params: { id: account.id } }
 | 
			
		||||
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: admin) }
 | 
			
		||||
    let(:account) { Fabricate(:account, user: user) }
 | 
			
		||||
    let(:user) { Fabricate(:user, disabled: true) }
 | 
			
		||||
 | 
			
		||||
    context 'when user is admin' do
 | 
			
		||||
      let(:admin) { true }
 | 
			
		||||
 | 
			
		||||
      it 'succeeds in enabling account' do
 | 
			
		||||
        is_expected.to redirect_to admin_account_path(account.id)
 | 
			
		||||
        expect(user.reload).not_to be_disabled
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    context 'when user is not admin' do
 | 
			
		||||
      let(:admin) { false }
 | 
			
		||||
 | 
			
		||||
      it 'fails to enable account' do
 | 
			
		||||
        is_expected.to have_http_status :forbidden
 | 
			
		||||
        expect(user.reload).to be_disabled
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
  describe 'POST #disable' do
 | 
			
		||||
    subject { post :disable, params: { id: account.id } }
 | 
			
		||||
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: current_user_admin) }
 | 
			
		||||
    let(:account) { Fabricate(:account, user: user) }
 | 
			
		||||
    let(:user) { Fabricate(:user, disabled: false, admin: target_user_admin) }
 | 
			
		||||
 | 
			
		||||
    context 'when user is admin' do
 | 
			
		||||
      let(:current_user_admin) { true }
 | 
			
		||||
 | 
			
		||||
      context 'when target user is admin' do
 | 
			
		||||
        let(:target_user_admin) { true }
 | 
			
		||||
 | 
			
		||||
        it 'fails to disable account' do
 | 
			
		||||
          is_expected.to have_http_status :forbidden
 | 
			
		||||
          expect(user.reload).not_to be_disabled
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
 | 
			
		||||
      context 'when target user is not admin' do
 | 
			
		||||
        let(:target_user_admin) { false }
 | 
			
		||||
 | 
			
		||||
        it 'succeeds in disabling account' do
 | 
			
		||||
          is_expected.to redirect_to admin_account_path(account.id)
 | 
			
		||||
          expect(user.reload).to be_disabled
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    context 'when user is not admin' do
 | 
			
		||||
      let(:current_user_admin) { false }
 | 
			
		||||
 | 
			
		||||
      context 'when target user is admin' do
 | 
			
		||||
        let(:target_user_admin) { true }
 | 
			
		||||
 | 
			
		||||
        it 'fails to disable account' do
 | 
			
		||||
          is_expected.to have_http_status :forbidden
 | 
			
		||||
          expect(user.reload).not_to be_disabled
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
 | 
			
		||||
      context 'when target user is not admin' do
 | 
			
		||||
        let(:target_user_admin) { false }
 | 
			
		||||
 | 
			
		||||
        it 'fails to disable account' do
 | 
			
		||||
          is_expected.to have_http_status :forbidden
 | 
			
		||||
          expect(user.reload).not_to be_disabled
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
  describe 'POST #redownload' do
 | 
			
		||||
    subject { post :redownload, params: { id: account.id } }
 | 
			
		||||
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: admin) }
 | 
			
		||||
    let(:account) { Fabricate(:account) }
 | 
			
		||||
 | 
			
		||||
    context 'when user is admin' do
 | 
			
		||||
      let(:admin) { true }
 | 
			
		||||
 | 
			
		||||
      it 'succeeds in redownloadin' do
 | 
			
		||||
        is_expected.to redirect_to admin_account_path(account.id)
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    context 'when user is not admin' do
 | 
			
		||||
      let(:admin) { false }
 | 
			
		||||
 | 
			
		||||
      it 'fails to redownload' do
 | 
			
		||||
        is_expected.to have_http_status :forbidden
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
 | 
			
		||||
  describe 'POST #remove_avatar' do
 | 
			
		||||
    subject { post :remove_avatar, params: { id: account.id } }
 | 
			
		||||
 | 
			
		||||
    let(:current_user) { Fabricate(:user, admin: admin) }
 | 
			
		||||
    let(:account) { Fabricate(:account) }
 | 
			
		||||
 | 
			
		||||
    context 'when user is admin' do
 | 
			
		||||
      let(:admin) { true }
 | 
			
		||||
 | 
			
		||||
      it 'succeeds in removing avatar' do
 | 
			
		||||
        is_expected.to redirect_to admin_account_path(account.id)
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    context 'when user is not admin' do
 | 
			
		||||
      let(:admin) { false }
 | 
			
		||||
 | 
			
		||||
      it 'fails to remove avatar' do
 | 
			
		||||
        is_expected.to have_http_status :forbidden
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
end
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user