techhub/mastodon
2
0
Fork 0
Code Activity

Simplify basic presence validations (#29664)

Browse Source
This commit is contained in:
Matt Jankowski
2024-09-05 11:36:05 -04:00
committed by GitHub
parent bc435c63bd
commit 5acec087ca
16 changed files with 28 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
spec/models/ip_block_spec.rb
View File

@@ -4,19 +4,8 @@ require 'rails_helper'
RSpec.describe IpBlock do
describe 'validations' do
it 'validates ip presence', :aggregate_failures do
ip_block = described_class.new(ip: nil, severity: :no_access)
expect(ip_block).to_not be_valid
expect(ip_block).to model_have_error_on_field(:ip)
end
it 'validates severity presence', :aggregate_failures do
ip_block = described_class.new(ip: '127.0.0.1', severity: nil)
expect(ip_block).to_not be_valid
expect(ip_block).to model_have_error_on_field(:severity)
end
it { is_expected.to validate_presence_of(:ip) }
it { is_expected.to validate_presence_of(:severity) }
it 'validates ip uniqueness', :aggregate_failures do
described_class.create!(ip: '127.0.0.1', severity: :no_access)