techhub/mastodon
2
0
Fork 0
Code Activity

Change quote verification to not bypass authorization flow for mentions (#35528)

Browse Source
This commit is contained in:
Claire
2025-07-31 09:39:53 +02:00
committed by GitHub
parent 2131d1ff23
commit 572a0e128d
7 changed files with 13 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/models/concerns/status/interaction_policy_concern.rb
View File

@@ -33,16 +33,8 @@ module Status::InteractionPolicyConcern
automatic_policy = quote_approval_policy >> 16
manual_policy = quote_approval_policy & 0xFFFF
# Checking for public policy first because it's less expensive than looking at mentions
return :automatic if automatic_policy.anybits?(QUOTE_APPROVAL_POLICY_FLAGS[:public])
# Mentioned users are always allowed to quote
if active_mentions.loaded?
return :automatic if active_mentions.any? { |mention| mention.account_id == other_account.id }
elsif active_mentions.exists?(account: other_account)
return :automatic
end
if automatic_policy.anybits?(QUOTE_APPROVAL_POLICY_FLAGS[:followers])
following_author = preloaded_relations[:following] ? preloaded_relations[:following][account_id] : other_account.following?(account) if following_author.nil?
return :automatic if following_author