Merge pull request from GHSA-vp5r-5pgw-jwqx
* Fix streaming sessions not being closed when revoking access to an app * Add tests for GHSA-7w3c-p9j8-mq3x
This commit is contained in:
		@@ -50,9 +50,11 @@ describe Oauth::AuthorizedApplicationsController do
 | 
			
		||||
    let!(:application) { Fabricate(:application) }
 | 
			
		||||
    let!(:access_token) { Fabricate(:accessible_access_token, application: application, resource_owner_id: user.id) }
 | 
			
		||||
    let!(:web_push_subscription) { Fabricate(:web_push_subscription, user: user, access_token: access_token) }
 | 
			
		||||
    let(:redis_pipeline_stub) { instance_double(Redis::Namespace, publish: nil) }
 | 
			
		||||
 | 
			
		||||
    before do
 | 
			
		||||
      sign_in user, scope: :user
 | 
			
		||||
      allow(redis).to receive(:pipelined).and_yield(redis_pipeline_stub)
 | 
			
		||||
      post :destroy, params: { id: application.id }
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
@@ -67,5 +69,9 @@ describe Oauth::AuthorizedApplicationsController do
 | 
			
		||||
    it 'removes the web_push_subscription' do
 | 
			
		||||
      expect { web_push_subscription.reload }.to raise_error(ActiveRecord::RecordNotFound)
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    it 'sends a session kill payload to the streaming server' do
 | 
			
		||||
      expect(redis_pipeline_stub).to have_received(:publish).with("timeline:access_token:#{access_token.id}", '{"event":"kill"}')
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
end
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user