techhub/mastodon
2
0
Fork 0
Code Activity

Use body_as_json directly instead of via local var assignment (#31696)

Browse Source
This commit is contained in:
Matt Jankowski
2024-09-03 04:03:08 -04:00
committed by GitHub
parent e5155c50fd
commit 24a0b20408
15 changed files with 123 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
spec/requests/api/v1/admin/ip_blocks_spec.rb
View File

@@ -88,10 +88,12 @@ RSpec.describe 'IP Blocks' do
subject
expect(response).to have_http_status(200)
json = body_as_json
expect(json[:ip]).to eq("#{ip_block.ip}/#{ip_block.ip.prefix}")
expect(json[:severity]).to eq(ip_block.severity.to_s)
expect(body_as_json)
.to include(
ip: eq("#{ip_block.ip}/#{ip_block.ip.prefix}"),
severity: eq(ip_block.severity.to_s)
)
end
context 'when ip block does not exist' do
@@ -118,11 +120,12 @@ RSpec.describe 'IP Blocks' do
subject
expect(response).to have_http_status(200)
json = body_as_json
expect(json[:ip]).to eq("#{params[:ip]}/32")
expect(json[:severity]).to eq(params[:severity])
expect(json[:comment]).to eq(params[:comment])
expect(body_as_json)
.to include(
ip: eq("#{params[:ip]}/32"),
severity: eq(params[:severity]),
comment: eq(params[:comment])
)
end
context 'when the required ip param is not provided' do