techhub/mastodon
2
0
Fork 0
Code Activity

Replace local vars with let in JS-enabled system specs (#34905)

Browse Source
This commit is contained in:
Matt Jankowski
2025-06-05 03:08:52 -04:00
committed by GitHub
parent 250c3b0c1f
commit 1d152d2181
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/system/account_notes_spec.rb
View File

@@ -11,13 +11,13 @@ RSpec.describe 'Account notes', :inline_jobs, :js, :streaming do
let(:finished_onboarding) { true } let(:finished_onboarding) { true }
let!(:other_account) { Fabricate(:account) } let!(:other_account) { Fabricate(:account) }
let(:note_text) { 'This is a personal note' }
before { as_a_logged_in_user } before { as_a_logged_in_user }
it 'can be written and viewed' do it 'can be written and viewed' do
visit_profile(other_account) visit_profile(other_account)
note_text = 'This is a personal note'
fill_in frontend_translations('account_note.placeholder'), with: note_text fill_in frontend_translations('account_note.placeholder'), with: note_text
# This is a bit awkward since there is no button to save the change # This is a bit awkward since there is no button to save the change

2
spec/system/new_statuses_spec.rb
View File

@@ -9,12 +9,12 @@ RSpec.describe 'NewStatuses', :inline_jobs, :js, :streaming do
let(:password) { 'password' } let(:password) { 'password' }
let(:confirmed_at) { Time.zone.now } let(:confirmed_at) { Time.zone.now }
let(:finished_onboarding) { true } let(:finished_onboarding) { true }
let(:status_text) { 'This is a new status!' }
before { as_a_logged_in_user } before { as_a_logged_in_user }
it 'can be posted' do it 'can be posted' do
visit_homepage visit_homepage
status_text = 'This is a new status!'
within('.compose-form') do within('.compose-form') do
fill_in frontend_translations('compose_form.placeholder'), with: status_text fill_in frontend_translations('compose_form.placeholder'), with: status_text